Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batcher): Update SP1 and Risc0 version in batcher, examples, and docs #1329

Merged
merged 49 commits into from
Nov 8, 2024

Conversation

PatStiles
Copy link
Contributor

Update Batcher SP1 and Risc0 version

Description

Complements #1324
Updates the SP1 and Risc0 version in the:

  • batcher
  • examples
  • docs
    Renames the test files for SP1 and Risc0 by changing the respective suffix to point towards the correct version ("" indicates removal of the suffix):
    "_new" -> ""
    "" -> "-> old

NOTE: Removal of the old verifier ffi bindings will occur in a third pr.

Type of change

  • New feature

@PatStiles PatStiles changed the base branch from testnet to staging October 25, 2024 18:17
@PatStiles PatStiles self-assigned this Oct 25, 2024
@PatStiles PatStiles force-pushed the 1205-update-batcher-examples-docs branch from 19fe6b6 to cc51dc0 Compare October 25, 2024 22:33
@MauroToscano MauroToscano changed the base branch from staging to testnet October 28, 2024 18:54
Copy link
Contributor

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's approved, but don't merge until operators upgrade

Copy link
Collaborator

@JuArce JuArce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cases tested in stage:

Operator version: v0.10.2

  1. Send old proofs with the old batcher: It is the previous version, and it works. The operator logs that it is using old version of the prover ✅
  2. Send new proofs with the old batcher: The batcher rejects the proofs ✅
  3. Send new proofs with the new batcher. The operator uses the new version of the provers ✅

Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected on Linux and macos!

@Oppen
Copy link
Collaborator

Oppen commented Nov 4, 2024

It's approved, but don't merge until operators upgrade

Updates on this?

@uri-99
Copy link
Contributor

uri-99 commented Nov 6, 2024

Still waiting , aprox 24hs and we eject unupgraded operators.

@MauroToscano MauroToscano merged commit 8e397d3 into testnet Nov 8, 2024
11 checks passed
@MauroToscano MauroToscano deleted the 1205-update-batcher-examples-docs branch November 8, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants